git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [GSoC][RFC] Replace use of atoi() with strtol_i(), as a microproject

From
Mohit Marathe <mohitmarathe@proton.me>
Date
Jan 17, 2024, 05:28 UTC
Message-ID
<Ec-xbd5ISDrcz8ybM8oJkVEhX7hgEmENoeek1n4K5M9buOfQ1SwOgGqAZRyMnYGYY1AFG1ppUKwXi3V63dndTzAjnJj7Cs0cVrtqwROg6oc=@proton.me>
In-Reply-To
<xmqqa5pdav04.fsf@gitster.g>
Show 6 quoted lines
> A corrupt patch may be getting a nonsense patch-ID with the current
> code and hopefully is not matching other patches that are not
> corrupt, but with such a change, a corrupt patch may not be getting
> any patch-ID and a loop that computes patch-ID for many files and
> try to match them up might need to be rewritten to take the new
> failure case into account.

Are you talking about the loop in `get_one_patchid()`? And how should the failure case be handled? Should it give a warning or an error?

Previous: Mohit Marathe
Message 8 of 8 in “[GSoC][RFC] Replace use of atoi() with strtol_i(), as a microproject”
  1. mohitmarathe@proton.meJan 8, 2024
  2. Christian CouderJan 9, 2024
  3. Mohit MaratheJan 10, 2024
  4. rsbecker@nexbridge.comJan 10, 2024
  5. Junio C HamanoJan 10, 2024
  6. Junio C HamanoJan 10, 2024
  7. Mohit MaratheJan 12, 2024
  8. Mohit MaratheJan 17, 2024

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.