Re: git-daemon breakage in 1.5.4

From: Wincent Colaiuta <win@wincent.com>
Date: Feb 6, 2008, 09:44 UTC
Message-ID: <EA30530E-B917-48CA-A43B-FAAF9721A9ED@wincent.com>
In-Reply-To: <7v3as6321y.fsf@gitster.siamese.dyndns.org>

El 6/2/2008, a las 9:46, Junio C Hamano escribió:

Show 10 quoted lines

> Wincent Colaiuta <win@wincent.com> writes:
>
>> This fails with the "remote end hung up unexpectedly" error:
>>
>>   # /usr/local/bin/git-daemon --inetd --base-path=/blah -- /blah
>>
>> Drop the --inetd option and it works with no errors:
>
> Do you mean you run the above from your command line and it
> fails?

Yes.

> I do not think --inetd mode is supposed to work as a daemon that
> accepts connections.  Wouldn't it be talking with a single peer
> via its stdin/stdout?

I don't know exactly what it does under the covers (will look now). Perhaps it detects that its running from an interactive login and modifies its behaviour. But all I can confirm is that in 1.5.3.8 (and before 511707d42b3b3e57d9623493092590546ffeae80) "git daemon" works from the command line both with and without the --inetd option, and in 1.5.4 (from that commit onwards) "git daemon" doesn't work for me with the --inetd option but it does without it. The testing from the command line is really only a diagnostic thing (perhaps misguided), but it does exhibit the same behaviour as issuing the same command within xinetd.

Cheers,

Wincent