Re: [PATCH] Include log_config module in apache.conf

From: Brian Gernhardt <benji@silverinsanity.com>
Date: Mar 11, 2009, 19:33 UTC
Message-ID: <E7E9DDFD-F8F6-4B39-A3E3-48CC1C8F5BBC@silverinsanity.com>
In-Reply-To: <7vab7r6g59.fsf@gitster.siamese.dyndns.org>

On Mar 11, 2009, at 2:58 PM, Junio C Hamano wrote:

Show 15 quoted lines

> diff --git a/t/lib-httpd/apache.conf b/t/lib-httpd/apache.conf
> index a0d4077..f460e40 100644
> --- a/t/lib-httpd/apache.conf
> +++ b/t/lib-httpd/apache.conf
> @@ -4,7 +4,9 @@ DocumentRoot www
> LogFormat "%h %l %u %t \"%r\" %>s %b" common
> CustomLog access.log common
> ErrorLog error.log
> -LoadModule log_config_module modules/mod_log_config.so
> +<IfModule !mod_log_config.c>
> +	LoadModule log_config_module modules/mod_log_config.so
> +</IfModule>
>
> <IfDefine Darwin>
> 	LoadModule log_config_module modules/mod_log_config.so

Isn't this last line redundant now?