git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCHv2] Have manpage reference new documentation on reverting merges.

From
Boyd Stephen Smith Jr. <bss@iguanasuicide.net>
Date
Dec 21, 2008, 21:35 UTC
Message-ID
<E1LEVxk-0001jS-Cc@rei.iguanasuicide.net>
In-Reply-To
<7vtz8ytft0.fsf@gitster.siamese.dyndns.org>
Signed-off-by: Boyd Stephen Smith Jr <bss@iguanasuicide.net>
---
On Saturday 2008 December 20 20:36:43 Junio C Hamano wrote:
Show 7 quoted lines
> "Boyd Stephen Smith Jr." <bss@iguanasuicide.net> writes:
> > +	Reverting a merge commit does not completely "undo" the effect of the
> > +	merge and it may make future merges more difficult.  For more details,
> > +	please read Documentation/howto/revert-a-faulty-merge.txt.
>
> I think these new lines need to be dedented, and the previous blank line
> should be turned into a line with a single '+'.
Fixed, I wasn't familiar with asciidoc.
Show 8 quoted lines
> I'd also suggest removing "does not ... merge and it" from the above
> sentence to avoid confusing readers, because people who read only the
> above and do not read the howto document may get a wrong impression that
> the resulting tree may have some changes that came from the merge even
> after the revert, which is not the case.
>
> An alternative is to give a complete but brief explanation.  Perhaps like
> this:
I took the alternative approach.
 Documentation/git-revert.txt |    7 +++++++
 1 files changed, 7 insertions(+), 0 deletions(-)
diff --git a/Documentation/git-revert.txt b/Documentation/git-revert.txt
index caa0729..daa77a9 100644
--- a/Documentation/git-revert.txt
+++ b/Documentation/git-revert.txt
@@ -44,6 +44,13 @@ OPTIONS
 	option specifies the parent number (starting from 1) of
 	the mainline and allows revert to reverse the change
 	relative to the specified parent.
++
+Reverting a merge commit declares to git that you will never want the tree
+changes brought in by the merge but never alters the history changes caused by
+the merge.  The history allows git to remember you rejected the tree changes
+and, as a result, later merges will only bring in changes introduced by commits
+that are not ancestors of the revert commit.  This may or may not be what you
+want.  See the 'revert-a-faulty-merge' HOWTO for more details.
 
 --no-edit::
 	With this option, 'git-revert' will not start the commit
-- 
1.5.6
-- 
Boyd Stephen Smith Jr.                     ,= ,-_-. =. 
bss@iguanasuicide.net                     ((_/)o o(\_))
ICQ: 514984 YM/AIM: DaTwinkDaddy           `-'(. .)`-' 
http://iguanasuicide.net/                      \_/     
Previous: Junio C HamanoNext: Junio C Hamano
Message 5 of 7 in “Have manpage reference new documentation on reverting merges.”
  1. Have manpage reference new documentation on reverting merges.Boyd Stephen Smith Jr., Dec 21, 2008
  2. Junio C HamanoDec 21, 2008
  3. Boyd Stephen Smith Jr.Dec 21, 2008
  4. Junio C HamanoDec 21, 2008
  5. [PATCHv2] Have manpage reference new documentation on reverting merges.Boyd Stephen Smith Jr., Dec 21, 2008
  6. Junio C HamanoDec 21, 2008
  7. [PATCHv3] Have git revert documentation reference new HOWTO on reverting faulty merges.Boyd Stephen Smith Jr., Dec 22, 2008

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.