Re: [RFC PATCH] repack: make repack -a equivalent to repack -A and drop previous -a behavior

From: Brandon Casey <casey@nrlssc.navy.mil>
Date: Nov 14, 2008, 01:36 UTC
Message-ID: <Dei99j9xFoGAh0A3LCO0zx3LqCb4lViSZpGvv_KGn38@cipher.nrlssc.navy.mil>
In-Reply-To: <20081114012502.GC5285@atjola.homenet>

Björn Steinbrink wrote:

Show 15 quoted lines

> On 2008.11.13 18:53:29 -0600, Brandon Casey wrote:
>> Björn Steinbrink wrote:
>>> I didn't check all the (proposed) commits for that branch, so just let
>>> me know if I'm missing anything, but doesn't this change mean that you
>>> just lose what "-ad" did?
>> yes.
>>
>>> We have:
>>> 	-a	Create a new pack, containing all reachable objects
>>> 	-A	Same as -a
>>> 	-ad	Same as -a, and drop all old packs and loose objects
>> by loose objects, I assume you mean packed unreachable objects.
> 
> No, actually I just totally ignored the fact that -a of course already
> deletes the loose objects.

Actually, I had forgotten that repack deletes any loose objects at all. It does call prune-packed, but only when -d is used.

Show 5 quoted lines

> IMHO, "git gc" already provides enough safety. I tend to see "gc" as the
> regular "just use it" tool, while repack gives me more control over how
> I want things to be done, without forcing me to use the real plumbing or
> to fumble around with the configuration for gc. And when I want control,
> I'm generally prepared to shoot myself in the foot.

I think you're right. Thanks for providing an example of a real use case.

-brandon