git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v3] range-diff: add --matched-only to skip one-sided commits

From
Matt Hunter <m@lfurio.us>
Date
Nov 3, 2026, 01:56 UTC
Message-ID
<DML7B6VVFDH0.3RKFXWKOH0X2L@lfurio.us>
In-Reply-To
<427F4BDB-B21B-468E-9C6A-4A7FE3F13688@gmail.com>
On Mon Nov 2, 2026 at 8:10 PM EST, Ben Knoble wrote:
Show 11 quoted lines
>> Le 2 nov. 2026 à 19:16, Junio C Hamano <gitster@pobox.com> a écrit :
>> 
>> I thought Harald's case was to take the patches from the previous
>> round of the topic and rebase them on top of a different base (e.g.,
>> updated origin/master), so there is no suitable single <base> for
>> the three-rev form, but I may have misunderstood his example.
>
> I think origin..old-topic and origin..new-topic 
> would both select only the “topic” commits as long as both
> bases are reachable from origin (which seems to be the
> described case, to me).

Put another way, every commit reachable from origin is excluded from either side of the range-diff.

Harald's example uses the symmetric difference syntax. I think this effectively treats the merge-base of the two tips as the shared base in the range-diff. It can't tell the difference between new commits that are part of the topic and ones that are only there by virtue of advancing the topic's (real) base.

So, I think this <A>...<B> form would yield the expected output if you only rewrote history in-place _on the same base commit_, but not in the general case?

>
> I agree with Matt that better selection of inputs to range-diff 
> makes this specific case better :) 

When I run this command, I almost always say it like this (with the topic checked out)

    git range-diff master @{1} @
                          ^
                          or, @{u}
                depending on the workflow
Previous: Ben KnobleNext: Junio C Hamano
Message 18 of 23 in “range-diff: add --matched-only to skip one-sided commits”
  1. range-diff: add --matched-only to skip one-sided commitsHarald Nordgren via GitGitGadget, Sep 11, 2026
  2. Junio C HamanoSep 11, 2026
  3. Harald NordgrenSep 11, 2026
  4. Junio C HamanoSep 11, 2026
  5. Harald NordgrenSep 11, 2026
  6. Junio C HamanoSep 11, 2026
  7. range-diff: add --matched-only to skip one-sided commitsHarald Nordgren via GitGitGadget, Sep 11, 2026
  8. Junio C HamanoSep 14, 2026
  9. range-diff: add --matched-only to skip one-sided commitsHarald Nordgren via GitGitGadget, Sep 15, 2026
  10. Junio C HamanoNov 2, 2026
  11. Harald NordgrenNov 2, 2026
  12. Ben KnobleNov 2, 2026
  13. Harald NordgrenNov 2, 2026
  14. Harald NordgrenNov 2, 2026
  15. Matt HunterNov 3, 2026
  16. Junio C HamanoNov 3, 2026
  17. Ben KnobleNov 3, 2026
  18. Matt HunterNov 3, 2026
  19. Junio C HamanoNov 3, 2026
  20. Kristoffer HaugsbakkNov 4, 2026
  21. Ben KnobleNov 4, 2026
  22. Kristoffer HaugsbakkNov 4, 2026
  23. Junio C HamanoNov 2, 2026

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.