Re: [PATCH v4] utf8: replace utf8_strwidth todo with descriptive comment

From: Hardik Kumar <hardikxk@gmail.com>
Date: Jul 28, 2026, 17:04 UTC
Message-ID: <DKAD8F8VLOMQ.3KKRGKVG6UT02@gmail.com>
In-Reply-To: <c8fb2eba-c1c8-4f59-b467-e6d4766623d8@gmail.com>

On Tue Jul 28, 2026 at 9:11 PM IST, Phillip Wood wrote:

Show 7 quoted lines

> The last sentence does not really capture the reasons given in the 
> message of the commit that added this comment. If you haven't done so 
> already you should read it - see 937b71cc8b (utf8: fix overflow when 
> returning string width, 2022-12-01). The fundamental reason to call 
> cast_size_t_to_int(), rather than relying on an implicit conversion to 
> the return type, is not about changing signatures, it is about avoiding 
> an overflow that caused git to crash.

I did check that commit before. My attempt at explaining the reason wasn't quite right. I have improved it in the next patch.

Thanks for the review. Hardik