Re: [PATCH] typo: fix the typo 'neeed' into 'needed' in the comment under merge-ort.c
- From
王常新 <wchangxin824@gmail.com>
- Date
- Oct 21, 2023, 01:22 UTC
- Message-ID
- <DE904895-230C-436E-B7DE-499E6E503DB9@gmail.com>
- In-Reply-To
- <xmqqv8b1s0pf.fsf@gitster.g>
Show 13 quoted lines
> 2023年10月21日 00:44,Junio C Hamano <gitster@pobox.com> 写道: > > 王常新 <wchangxin824@gmail.com> writes: > >> It is my official name. But the email address is not a valid one. Should I rewrite the commit message? > > We try to keep the name and address on Signed-off-by: the official > one that we can give court if/when some copyright troll sues us (see > Documentation/SubmittingPatches:sign-off), and one of them (if more > than one developers signed off the patch) must match the primary > author's name and address. > > Thanks.
Sorry about that, I am not quite familiar with the process. I mean I can receive emails at both @qq.com and @gmail.com, but <foril@foril.space> in the signed-off-by trailer in the commit message doesn’t actually exist.
Given this situation, I am unsure of the next steps to correct this issue. Would it be appropriate for me to use 'rebase -i' to amend the erroneous commit message, followed by a force push to update the PR on GitHub? After this, is the correct following step to add another comment with "/submit" to finalize the changes?
Sincerely apologize for any inconvenience my mistake may have caused and appreciate your guidance on resolving this matter. Your patience and support in this learning process mean a lot to me.