RE: git commit results in many lstat()s
- From
Gumbel, Matthew K <matthew.k.gumbel@intel.com>
- Date
- Feb 2, 2017, 00:14 UTC
- Message-ID
- <DA0A42D68346B1469147552440A645039A9C5929@ORSMSX115.amr.corp.intel.com>
- In-Reply-To
- <xmqq60ktmpwl.fsf@gitster.mtv.corp.google.com>
"Junio C Hamano <mailto:jch2355@gmail.com> writes:
"Gumbel, Matthew K" <matthew.k.gumbel@intel.com> writes:
>> Yes, I think that when the user passes --only flag to git-commit, then git does not >> need to call refresh_cache() in prepare_index() in builtin/commit.c. >> >> I may experiment with that. Do you see any downside or negative side-effects?
> There may be other fallouts, but one that immediately comes to mind > is that it may break pre-commit hook.
If pre-commit hook exists, we can fall-back to original behavior and call refresh_cache(). Many repos will not have pre-commit hook and can benefit from the speedup.
I'm testing such a change locally. Git test suite seems to be running for quite a while. Do you know any way to run it in parallel or otherwise speed it up?
Thanks, Matt