git/list[1] front-page[2] threads[3] people[4] search[5] about
 

RE: git commit results in many lstat()s

From
Gumbel, Matthew K <matthew.k.gumbel@intel.com>
Date
Feb 2, 2017, 00:14 UTC
Message-ID
<DA0A42D68346B1469147552440A645039A9C5929@ORSMSX115.amr.corp.intel.com>
In-Reply-To
<xmqq60ktmpwl.fsf@gitster.mtv.corp.google.com>
"Junio C Hamano <mailto:jch2355@gmail.com> writes:
"Gumbel, Matthew K" <matthew.k.gumbel@intel.com> writes:
>> Yes, I think that when the user passes --only flag to git-commit, then git does not
>> need to call refresh_cache() in prepare_index() in builtin/commit.c.
>>
>> I may experiment with that. Do you see any downside or negative side-effects?
> There may be other fallouts, but one that immediately comes to mind
> is that it may break pre-commit hook.

If pre-commit hook exists, we can fall-back to original behavior and call refresh_cache(). Many repos will not have pre-commit hook and can benefit from the speedup.

I'm testing such a change locally. Git test suite seems to be running for quite a while. Do you know any way to run it in parallel or otherwise speed it up?

Thanks, Matt

Previous: Junio C HamanoNext: brian m. carlson
Message 5 of 6 in “git commit results in many lstat()s”
  1. Gumbel, Matthew KFeb 1, 2017
  2. Junio C HamanoFeb 1, 2017
  3. Gumbel, Matthew KFeb 1, 2017
  4. Junio C HamanoFeb 1, 2017
  5. Gumbel, Matthew KFeb 2, 2017
  6. brian m. carlsonFeb 2, 2017

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.