Re: [PATCH rfc v2] git-sh-setup: Fix scripts whose PWD is a symlink to a work-dir on OS X
- From
Wincent Colaiuta <win@wincent.com>
- Date
- Jan 4, 2009, 13:58 UTC
- Message-ID
- <D9F420FC-12C5-4262-833B-0820D8C80AC9@wincent.com>
- In-Reply-To
- <7v8wps59ss.fsf@gitster.siamese.dyndns.org>
El 3/1/2009, a las 23:01, Junio C Hamano escribió:
Show 16 quoted lines
> "Marcel M. Cary" <marcel@oak.homeunix.org> writes: > >> I sent the first rev of this patch to just Brian. It didn't have >> either of the unit test changes. He said it fixed all but t2300.3, >> where cd_to_toplevel doesn't actually "cd", so I made the same change >> to the unit test itself. Can someone with OS X try running the test >> suite with v2 of this patch? I don't have OS X readily available. > > I think I saw a success report on the list. Care to resend it with > Sign-off (by you) and > > Tested-by: tester <test@er.xz> (on PLATFORM) > > lines as you see necessary for application? > > Thanks.
I also tested it and can confirm that it fixes the failures on Mac OS X 10.5.5. So feel free to add:
Tested-by: Wincent Colaiuta <win@wincent.com> (on Mac OS X 10.5.5)
Cheers, Wincent