Re: [PATCH v2 0/3] Ensure unique worktree ids across repositories

From: Caleb White <cdwhite3@pm.me>
Date: Nov 29, 2024, 23:13 UTC
Message-ID: <D5Z1L479JERN.80KZ7NA9BWNJ@pm.me>
In-Reply-To: <00c401db42b1$99c4d5a0$cd4e80e0$@nexbridge.com>

On Fri Nov 29, 2024 at 4:54 PM CST, rsbecker wrote:

> General comment on this series: Is there a mechanism of preserving existing
> functionality for those of us who have existing scripts that depend on the
> existing branch and worktree naming?

Existing worktrees will continue to work as they do now. The only change is the worktree id for new worktrees. However, there's not an option to preserve the existing behavior for new worktrees (nor do I think there should be).

As stated in the v1 threads, the worktree id is already not guaranteed to be equal to the worktree/branch name (there's several ways that this can occur), so it's buggy behavior for scripts to make this assumption. Any script that needs the worktree id should be parsing it from the `.git` file, `git rev-parse --git-dir`, or (with the changes in this series) `git worktree list`.

Best,

Caleb