Re: [PATCH 1/2] worktree: add CLI/config options for relative path linking

From: Caleb White <cdwhite3@pm.me>
Date: Oct 28, 2024, 18:50 UTC
Message-ID: <D57NXXVF7BEW.2JASTW8099JUI@pm.me>
In-Reply-To: <Zx/B3caIgAeAv6Kz@nand.local>

On Mon Oct 28, 2024 at 11:54 AM CDT, Taylor Blau wrote:

Show 11 quoted lines

> On Mon, Oct 28, 2024 at 04:35:22PM +0000, Caleb White wrote:
>> Thanks for catching this, the issue is that there's a bug in the
>> `initialize_repository_version()` function when reinitializing a
>> repository---the function doesn't check if there are other extensions
>> in use before downgrading the repository version to 0.
>>
>> This is a rare edge case, but I'll work on a fix.
>
> I am confused... are you saying t0001.46 is flaky? I don't think that
> it is, as it fails consistently for me with your patches applied when
> ran in a loop.

No, the test is not flaky. Adding the extension just revealed a bug in the code that was not caught by the test suite. I've fixed the bug and will push v2 here shortly.

Show 7 quoted lines

> I am definitely guilty of having sent broken patches to the list before
> that fail CI, usually when I have amended something I thought was
> trivial after already running the test suite on all patches, only to
> realize that it wasn't trivial after all and instead broken something.
>
> But please do be careful to thoroughly vet your patches before sending
> them to the list, as this sort of breakage can be disruptive.

The test suite was passing, I must've just forgotten to execute this again test after I added the extension. I'll be more careful in the future.

Best, Caleb