Re: [GSoC][PATCH v5] t: port helper/test-hashmap.c to unit-tests/t-hashmap.c

From: Ghanshyam Thakkar <shyamthakkar001@gmail.com>
Date: Aug 7, 2024, 14:44 UTC
Message-ID: <D39RDAEXKU68.10JTFKUKJ6YHH@gmail.com>
In-Reply-To: <CAP8UFD3VwiAbGvzgi14EcEQLX6Gs7pNy+dvZcXkPOueKpJS7HA@mail.gmail.com>

Christian Couder <christian.couder@gmail.com> wrote:

Show 8 quoted lines

> On Sat, Aug 3, 2024 at 3:35 PM Ghanshyam Thakkar
> <shyamthakkar001@gmail.com> wrote:
>
> > Range-diff against v4:
>
> Nit (not worth a reroll): the range-diff usually goes before the
> actual patch in the section starting with a line containing only 3
> dashes

'format-patch' placed it here by itself. Looking at the release notes for 2.46 I found this:

 * The inter/range-diff output has been moved to the end of the patch
   when format-patch adds it to a single patch, instead of writing it
   before the patch text, to be consistent with what is done for a
   cover letter for a multi-patch series.

Thanks.