Re: Git pull stuck when Trace2 target set to Unix Stream Socket

From: Son Luong Ngoc <sluongng@gmail.com>
Date: Apr 13, 2020, 17:19 UTC
Message-ID: <D350F464-61DE-4EB6-BBE1-514A0C051F38@gmail.com>
In-Reply-To: <20200413160051.GB59601@syl.local>

Hi Taylor,

Thanks for the swift reply.

Show 7 quoted lines

> On Apr 13, 2020, at 18:00, Taylor Blau <me@ttaylorr.com> wrote:
> I doubt that this is important (for a reason that I'll point out below),
> but it looks like your invocation here is malformed with the trailing
> pipe character.
> 
> Did you mean to redirect the output of rm away? If so, '2>&1 >/dev/null'
> will do what you want.

It was an emailing mistake. I meant to write

> rm /tmp/git_trace.sock || true

So that the command is reproducible on repeated run. I must have deleted the remaining part by mistake.

Show 5 quoted lines

> Odd. From my memory, trace2 will give up trying to connect to the socket
> (disabling itself and optionally printing a warning) if 'socket(2)' or
> 'connect(2)' set the error bit. My guess above is that you don't have a
> listening socket (because your shell is waiting for you to close the
> '|'), so there's no connection to be made.

There is definitely connection still, as I can still receive more events after interupting the stuck git command by Ctrl-C.

> Odd. What version of Git are you using? Your description makes it
> sound like it may be a bug, so I'd be curious to hear Jeff's
> interpretation of things, too.

2.26.0 built from Master git/git

For more info, I have created a paste to demonstrate the bug https://gist.github.com/sluongng/e14563e4ce3cc9545781ecd5a95169f6 In which, I run `git pull origin` and `git version` on a relatively stale https://gitlab.com/gitlab-org/gitlab.git local copy.

You can get more information from the trace in that paste. I have annotated the moment which the stuck happened with `It stucks HERE` phrase so look for it.

Cheers, Son Luong.