Re: [PATCH 1/4] Makefile: extract script to lint missing/extraneous manpages

From: James Liu <james@jamesliu.io>
Date: Jun 6, 2024, 06:03 UTC
Message-ID: <D1SPGQ8OOLLS.I6HUJZW81XLH@jamesliu.io>
In-Reply-To: <Zl_3TQrUHdb5osDA@tanuki>

On Wed Jun 5, 2024 at 3:27 PM AEST, Patrick Steinhardt wrote:

Show 14 quoted lines

> On Tue, Jun 04, 2024 at 10:20:54PM -0700, Junio C Hamano wrote:
> > Patrick Steinhardt <ps@pks.im> writes:
> > 
> > > +++ b/Documentation/lint-manpages.sh
> > > @@ -0,0 +1,82 @@
> > > +#!/usr/bin/env bash
> > 
> > I do not see much bash-ism here.  Unless absolutely needed, please
> > use "#!/bin/sh" instead.
>
> Ah, true. I initially did have some bash-isms, but got rid of them. Will
> adapt.
>
> Patrick

It looks like the script fails to run under /bin/sh: https://gitlab.com/gitlab-org/git/-/jobs/7021474555#L4365

Cheers, James