git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Author signature

From
DSDimitri Sabadie <hadronized@strongly-typed-thoughts.net>
Date
May 14, 2024, 18:31 UTC
Message-ID
<D19KZ1CBA7JF.27PYPL5X68543@strongly-typed-thoughts.net>
Hello!

I’ve moved away from the PR/MR git workflow to the email one and I’ve been delighted by it. However, there is one thing that feels a bit like a regression to me.

On the PR/MR workflow, if someone wants to contribute to my project, they can simply make a couple of commits and open a “Pull Request” or “Merge Request.” Once reviewed, I can decide to merge via several options:

* Creating a merge commit.
* Rebasing their commits.
* Asking the UI of the (centralized) system (GitHub, GitLab, etc.) to do

Whatever is decided, the commits end up in my repository and the author might have signed the commits and their signature is still there.

With the email workflow, from what I understand, `git am` has no way to keep the signature of the author — and I have not found anything going that direction with `git send-email` and `git format-patch`, and I think that the reason why is because the commit is modified to introduce the committer (committer being me here; the author being the contributor who sent the patch), whence the commit SHA changes. The author signature is simply dropped, and `git log --show-signature` only shows my GPG signature; not the author’s anymore!

So… I was wondering: since we can only sign commits, is there any way / work in progress to attach the author signature to a commit? To me, it would make sense to have something hierarchical: the comitter simply signs above what the author signed, and the author doesn’t sign the whole commit (I guess?), since we want to be able to change the commit hash.

What do you think?

Cheers, Dimitri

Next: brian m. carlson
Message 1 of 6 in “Author signature”
  1. Dimitri SabadieMay 14, 2024
  2. brian m. carlsonMay 14, 2024
  3. Konstantin RyabitsevMay 14, 2024
  4. Konstantin RyabitsevMay 14, 2024
  5. Dimitri SabadieJun 4, 2024
  6. Konstantin RyabitsevJun 4, 2024

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.