Re: [PATCH] git-p4: remove unnecessary semicolons at end of lines
- From
Brandon Casey <casey@nrlssc.navy.mil>
- Date
- Mar 6, 2009, 16:55 UTC
- Message-ID
- <CYOA8Q1cpfGtE1Pp6_ETXfSJevKv9ADmYIuq6_whU0qskk289fiiUw@cipher.nrlssc.navy.mil>
- In-Reply-To
- <20090306155322.GC12880@zoy.org>
Sam Hocevar wrote:
> This is a purely cosmetic patch that makes the git-p4 code look more > pythonish by getting rid of end-of-line semicolons.
I get the impression that you do not intend for the comments above to be part of the commit message. If that is true, then they should be placed further down after the '---' and before the diff-stat, or in some other way partitioned from the commit message (maybe using --->8--- notation). Otherwise they will _become_ part of the commit message if Junio applies this patch as-is.
-brandon
> git-p4: remove unnecessary semicolons at end of lines. > > Signed-off-by: Sam Hocevar <sam@zoy.org> > ---
Comments not intended to be part of the commit message go here, where they will be ignored by git-apply.
Show 8 quoted lines
> contrib/fast-import/git-p4 | 46 ++++++++++++++++++++++---------------------- > 1 files changed, 23 insertions(+), 23 deletions(-) > > diff --git a/contrib/fast-import/git-p4 b/contrib/fast-import/git-p4 > index 3832f60..7ea5ac6 100755 > --- a/contrib/fast-import/git-p4 > +++ b/contrib/fast-import/git-p4 > @@ -12,7 +12,7 @@ import optparse, sys, os, marshal, popen2, subprocess, shelve
<snip>