Typo spotted in archive-tar.c

From: Green, Paul <paul.green@stratus.com>
Date: May 24, 2016, 00:44 UTC
Message-ID: <CO2PR0801MB599926424BC99D7DFC2622B8E4F0@CO2PR0801MB599.namprd08.prod.outlook.com>

While examining (relatively) recent changes to git, my eye happened to notice the following inconsistency on line 184 of the current version of archive-tar.c.

-    sprintf(header->chksum, "%07o", ustar_header_chksum(header));
+    snprintf(header->chksum, sizeof(header->chksum), "%07o", ustar_header_chksum(header));

I believe the author meant to invoke the xsnprintf function, not the snprintf function. I say this because all of the other references to sprintf were indeed changed to xsnprintf, with the necessary additional 2nd argument.

This change was applied September 24, 2015 (commit f2f026752993054c1b712b6f4ae3ff167db38cbe).

See https://github.com/git/git/commit/f2f026752993054c1b712b6f4ae3ff167db38cbe#diff-d18f7cb5411066ed8eda566b26d2570c  for the full set of related changes to archive-tar.c.

Thanks
PG
--
Sr. Technical Consultant, Stratus Technologies, Inc.
5 Mill and Main, Suite 500, Maynard, MA 01754
Office: +1 (978) 461-7557, FAX: +1 (978) 461-3610