Re: [PATCH 3/3] builtin/checkout--worker: memset struct to avoid MSAN complaints

From: Chris Torek <chris.torek@gmail.com>
Date: Jun 11, 2021, 04:43 UTC
Message-ID: <CAPx1GvfF7NZD4RMWWZCfny2gQOt1GY=TUm1HxvC+kwwDsc4Rgw@mail.gmail.com>
In-Reply-To: <cd1e1f6985c77d21ec869e53dc5eb79673caf491.1623343713.git.gitgitgadget@gmail.com>

On Thu, Jun 10, 2021 at 9:49 AM Andrzej Hunt via GitGitGadget <gitgitgadget@gmail.com> wrote:

> [snip] Therefore we add a
> memset to convince MSAN that this memory is safe to read - but only
> when building with MSAN to avoid this cost in normal usage.

It does not seem likely to be that expensive, and would definitely be shorter without all the `#if` testing:

Show 6 quoted lines

> diff --git a/builtin/checkout--worker.c b/builtin/checkout--worker.c
> index 289a9b8f89d0..02fa5285988f 100644
> --- a/builtin/checkout--worker.c
> +++ b/builtin/checkout--worker.c
> @@ -56,6 +56,17 @@ static void report_result(struct parallel_checkout_item *pc_item)
>         struct pc_item_result res;

This could just have `= { 0 }` added.

In any case, this and all the others in this series look good to me.

Chris