Re: [PATCH] builtin/pack-objects.c: introduce `pack.extraCruftTips`
- From
Chris Torek <chris.torek@gmail.com>
- Date
- Apr 21, 2023, 00:10 UTC
- Message-ID
- <CAPx1GvdmzDVbiZGeguVVjWe+eAhj6=yG18Rd6wLhZVrnd4jiBg@mail.gmail.com>
- In-Reply-To
- <8af478ebe34539b68ffb9b353bbb1372dfca3871.1682011600.git.me@ttaylorr.com>
On Thu, Apr 20, 2023 at 10:35 AM Taylor Blau <me@ttaylorr.com> wrote:
> +Output must contain exactly one hex object ID per line, and nothing > +else. Objects which cannot be found in the repository are ignored.
The first part sounds good, as a rigid output format can always be relaxed later if necessary. The second I'm less sure about: should there perhaps be a --{no-,}missing-objects option to control it?
In particular I'd be a bit concerned if I always wanted to keep object $H and ran a command that is supposed to keep $H, but it was silently dropped (accidentally or not) and is then gone.
One could always run `gitt rev-parse` or `git cat-file -t` on the hash afterward to double check, I suppose...
Chris