Re: [PATCH v2 1/1] git mv foo FOO ; git mv foo bar gave an assert

From: Chris Torek <chris.torek@gmail.com>
Date: Mar 1, 2021, 19:36 UTC
Message-ID: <CAPx1GvcjO0-3nbcC_oYkYjhYenb_J9CoM6bZNaR_-t93cpppSw@mail.gmail.com>
In-Reply-To: <xmqqzgzmptmy.fsf@gitster.c.googlers.com>

On Mon, Mar 1, 2021 at 11:26 AM Junio C Hamano <gitster@pobox.com> wrote:

Show 7 quoted lines

> Before the problematic patch, this used to be
>
>                } else if (cache_name_pos(src, length) < 0)
>
> I wonder if we should revert the change to use cache_file_exists()
> in the first place (and rewrite the subsequent use of ce to match),
> though.

For what it's worth, that was what I did originally; the change to look up the ce "up front" was because someone objected to the double search implied by calling cache_name_pos once, then cache_file_exists to determine the correct error message...

(I've never been 100% on how the ignore-case stuff works internally.)

Chris