Re: [PATCH v1] t9821: use test_config
- From
Eric Sunshine <sunshine@sunshineco.com>
- Date
- Sep 3, 2015, 13:04 UTC
- Message-ID
- <CAPig+cTzeUKiFVvdsGBvvUg+9qOw6RWHdzuTgQRTWm5w0CeRcQ@mail.gmail.com>
- In-Reply-To
- <1441272887-72633-2-git-send-email-larsxschneider@gmail.com>
On Thu, Sep 3, 2015 at 5:34 AM, <larsxschneider@gmail.com> wrote:
Show 14 quoted lines
> From: Lars Schneider <larsxschneider@gmail.com> > > Signed-off-by: Lars Schneider <larsxschneider@gmail.com> > --- > diff --git a/t/t9821-git-p4-path-variations.sh b/t/t9821-git-p4-path-variations.sh > index 81e46ac..5a26fec 100755 > --- a/t/t9821-git-p4-path-variations.sh > +++ b/t/t9821-git-p4-path-variations.sh > @@ -45,7 +45,7 @@ test_expect_success 'Clone root' ' > ( > cd "$git" && > git init . && > - git config core.ignorecase false && > + test_config core.ignorecase false &&
test_config ensures that the config setting gets "unset" at the end of the test, whether the test succeeds or not, so that subsequent tests are not affected by the setting. However, in this case, since the $git repository gets recreated from scratch for each test anyhow, use of test_config is superfluous. In fact, it may be slightly contraindicated since it could mislead the reader into thinking that state is carried over from test to test. (Not a big objections, but something to take into consideration.)
Show 59 quoted lines
> git p4 clone --use-client-spec --destination="$git" //depot && > # This method is used instead of "test -f" to ensure the case is > # checked even if the test is executed on case-insensitive file systems. > @@ -67,7 +67,7 @@ test_expect_success 'Clone root (ignorecase)' ' > ( > cd "$git" && > git init . && > - git config core.ignorecase true && > + test_config core.ignorecase true && > git p4 clone --use-client-spec --destination="$git" //depot && > # This method is used instead of "test -f" to ensure the case is > # checked even if the test is executed on case-insensitive file systems. > @@ -91,7 +91,7 @@ test_expect_success 'Clone root and ignore one file' ' > ( > cd "$git" && > git init . && > - git config core.ignorecase false && > + test_config core.ignorecase false && > git p4 clone --use-client-spec --destination="$git" //depot && > # We ignore one file in the client spec and all path cases change from > # "TO" to "to"! > @@ -113,7 +113,7 @@ test_expect_success 'Clone root and ignore one file (ignorecase)' ' > ( > cd "$git" && > git init . && > - git config core.ignorecase true && > + test_config core.ignorecase true && > git p4 clone --use-client-spec --destination="$git" //depot && > # We ignore one file in the client spec and all path cases change from > # "TO" to "to"! > @@ -133,7 +133,7 @@ test_expect_success 'Clone path' ' > ( > cd "$git" && > git init . && > - git config core.ignorecase false && > + test_config core.ignorecase false && > git p4 clone --use-client-spec --destination="$git" //depot && > cat >expect <<-\EOF && > to/File2.txt > @@ -149,7 +149,7 @@ test_expect_success 'Clone path (ignorecase)' ' > ( > cd "$git" && > git init . && > - git config core.ignorecase true && > + test_config core.ignorecase true && > git p4 clone --use-client-spec --destination="$git" //depot && > cat >expect <<-\EOF && > TO/File2.txt > @@ -180,7 +180,7 @@ test_expect_success 'Add a new file and clone path with new file (ignorecase)' ' > ( > cd "$git" && > git init . && > - git config core.ignorecase true && > + test_config core.ignorecase true && > git p4 clone --use-client-spec --destination="$git" //depot && > cat >expect <<-\EOF && > to/File0.txt > -- > 1.9.5 (Apple Git-50.3)