Re: [PATCH 1/2] status: allow NULL fmt for status_printf/status_vprintf_ln

From: Eric Sunshine <sunshine@sunshineco.com>
Date: Mar 10, 2014, 20:13 UTC
Message-ID: <CAPig+cTzVO1kJCM0zTiDza+Na4PHeLpAr1dvqsXxfbmpy-egHA@mail.gmail.com>
In-Reply-To: <1394479647-22361-2-git-send-email-benoit.pierre@gmail.com>

On Mon, Mar 10, 2014 at 3:27 PM, Benoit Pierre <benoit.pierre@gmail.com> wrote:

Show 18 quoted lines

> Useful for calling status_printf only to change/reset the color (and
> output an additional '\n' with status_vprintf_ln).
>
> Signed-off-by: Benoit Pierre <benoit.pierre@gmail.com>
> ---
>  wt-status.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/wt-status.c b/wt-status.c
> index 4e55810..17f63a4 100644
> --- a/wt-status.c
> +++ b/wt-status.c
> @@ -49,7 +49,8 @@ static void status_vprintf(struct wt_status *s, int at_bol, const char *color,
>         struct strbuf linebuf = STRBUF_INIT;
>         const char *line, *eol;
>
> -       strbuf_vaddf(&sb, fmt, ap);
> +       if (NULL != fmt)

In this codebase,

    if (fmt)

would be more idiomatic.

Show 6 quoted lines

> +           strbuf_vaddf(&sb, fmt, ap);
>         if (!sb.len) {
>                 if (s->display_comment_prefix) {
>                         strbuf_addch(&sb, comment_line_char);
> --
> 1.9.0