Re: [PATCH 1/3] pretty: support "mboxrd" output format

From

Eric Sunshine <sunshine@sunshineco.com>

Date

May 31, 2016, 20:19 UTC

Message-ID

<CAPig+cTycj-N3FtkvRzWbm+UdYtQWBb6BCZH-798VLi+jOxy_Q@mail.gmail.com>

In-Reply-To

<CAPig+cSrqs7W2hSz6Z4_O9U52gUJFCqTSfRL0E0b=d=bO9RCEQ@mail.gmail.com>

On Tue, May 31, 2016 at 4:12 PM, Eric Sunshine <sunshine@sunshineco.com> wrote:

> On reflection, even with the '^' anchor, it isn't safe the way it's
> coded since '^' will match following a newline, won't it? Therefore,
> because 'line' isn't necessarily NUL-terminated, the pattern could
> match on some line beyond what get_one_line() considers the "current
> line".

> This makes the hand-coded is_mboxrd_from() even more attractive; plus
> you can re-use it in patch 2.