git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 3/5] generate-cmdlist: parse common group commands

From
Eric Sunshine <sunshine@sunshineco.com>
Date
May 14, 2015, 21:05 UTC
Message-ID
<CAPig+cTrDd3eYXo1WPoWRk5XSuLyH_m_VU1JsnP8pjkM=n6O2Q@mail.gmail.com>
In-Reply-To
<xmqq617ukhal.fsf@gitster.dls.corp.google.com>
On Thu, May 14, 2015 at 4:58 PM, Junio C Hamano <gitster@pobox.com> wrote:
Show 37 quoted lines
> Sébastien Guimmara  <sebastien.guimmara@gmail.com> writes:
>> From: Eric Sunshine <sunshine@sunshineco.com>
>>
>> Parse the [common] block to create the array of group descriptions:
>>
>> static char *common_cmd_groups[] = {
>>     N_("starting a working area"),
>>     N_("working on the current change"),
>>     N_("working with others"),
>>     N_("examining the history and state"),
>>     N_("growing, marking and tweaking your history"),
>> };
>>
>> then map each element of common_cmds[] to a group via its index:
>>
>> static struct cmdname_help common_cmds[] = {
>>     {"add", N_("Add file contents to the index"), 1},
>>     {"branch", N_("List, create, or delete branches"), 4},
>>     {"checkout", N_("Checkout a branch or paths to the ..."), 4},
>>     {"clone", N_("Clone a repository into a new directory"), 0},
>>     {"commit", N_("Record changes to the repository"), 4},
>>     ...
>> };
>>
>> so that 'git help' can print those commands grouped by theme.
>>
>> Only commands tagged with an attribute from [common] are emitted to
>> common_cmds[].
>>
>> [commit message by Sébastien Guimmara <sebastien.guimmara@gmail.com>]
>>
>> Signed-off-by: Eric Sunshine <sunshine@sunshineco.com>
>> Signed-off-by: Sébastien Guimmara <sebastien.guimmara@gmail.com>
>> ---
>
> I seem to be getting an empty common_cmds[] list after this step
> (with GNU Awk 4.0.1, ICIM).

Indeed. I haven't had a chance to look at this version of the series yet, but a quick glance shows that this is because patch 2/5 uses "common-" as a prefix rather than as a standalone tag. That is, lines in patch 2/5 like this:

    git-add  mainporcelain  common-worktree
should be:
    git-add  mainporcelain  common worktree

as proposed here[1]. And, then patch 4/5 should drop the standalone "common" tag rather than the "common-" prefix.

[1]: http://article.gmane.org/gmane.comp.version-control.git/268756
Previous: Junio C HamanoNext: Sébastien Guimmara
Message 6 of 12 in “git help: group common commands by theme”
  1. 0/5 git help: group common commands by themeSébastien Guimmara, May 14, 2015
  2. 1/5 command-list.txt: prepare with [commands] headerSébastien Guimmara, May 14, 2015
  3. 2/5 command-list.txt: add with [common] blockSébastien Guimmara, May 14, 2015
  4. 3/5 generate-cmdlist: parse common group commandsSébastien Guimmara, May 14, 2015
  5. Junio C HamanoMay 14, 2015
  6. Eric SunshineMay 14, 2015
  7. Sébastien GuimmaraMay 15, 2015
  8. 4/5 command-list.txt: drop the common- prefixSébastien Guimmara, May 14, 2015
  9. 5/5 help.c: output the typical Git workflowSébastien Guimmara, May 14, 2015
  10. 5/5 help.c: output the typical Git workflowSébastien Guimmara, May 14, 2015
  11. Junio C HamanoMay 14, 2015
  12. Sébastien GuimmaraMay 15, 2015

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.