Re: Git Test Coverage Report (Mon. Dec 9)

From: Eric Sunshine <sunshine@sunshineco.com>
Date: Dec 9, 2019, 17:19 UTC
Message-ID: <CAPig+cTrAsn64S0Qm7PdJVFhsquVA3+ugwngLpo1S4yUjMcrGA@mail.gmail.com>
In-Reply-To: <e47b77b4-7b7a-3d59-9e24-934528c5e297@web.de>

On Mon, Dec 9, 2019 at 12:11 PM René Scharfe <l.s.r@web.de> wrote:

Show 8 quoted lines

> Am 09.12.19 um 16:36 schrieb Derrick Stolee:
> > René Scharfe  0bb313a5 xdiff: unignore changes in function context
> > xdiff/xemit.c
> > 0bb313a5 223)        xchp->i1 + xchp->chg1 <= s1 &&
> > 0bb313a5 224)        xchp->i2 + xchp->chg2 <= s2)
> > 0bb313a5 225) xchp = xchp->next;
>
> Hmm, line 223 *is* exercised by t4015.85.

This, along with Dscho's[1] review of an earlier coverage report, makes one wonder if there is some off-by-one error in the reporting logic, such that it is reporting the wrong lines as not covered.

Footnotes:

[1]: https://lore.kernel.org/git/nycvar.QRO.7.76.6.1911262116100.31080@tvgsbejvaqbjf.bet/ which, among other seeming anomalies pointed out by Dscho, showed a closing brace '}' not covered by a test:

    > Johannes Schindelin 867bc1d2 rebase-merges: ...
    > sequencer.c
    > 867bc1d2 4539) }

    Not sure why this closing parenthesis isn't covered :-D