git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [GSOC][PATCH v4] t3701: don't lose "git" exit codes in test scripts

From
Eric Sunshine <sunshine@sunshineco.com>
Date
Apr 3, 2023, 06:24 UTC
Message-ID
<CAPig+cTq9mmLGmmNWQ0E73nsmwu+Lj1jDfvnniUe-O6iQrisnw@mail.gmail.com>
In-Reply-To
<20230402191709.19296-1-edwinfernando734@gmail.com>

On Sun, Apr 2, 2023 at 3:18 PM Edwin Fernando <edwinfernando734@gmail.com> wrote:

Show 11 quoted lines
> Exit codes are lost due to piping: "git ... | <command>"
> Fix these issues using the intermediate step of writing output to file.
>
> Signed-off-by: Edwin Fernando <edwinfernando734@gmail.com>
> ---
> Apply my changes on top of the latest commit in upstream history.
> Test 76 in t3701 fails. This commit breaks the test:
> a9f4a01760 (Merge branch 'jk/add-p-unmerged-fix', 2023-03-19)
> Identified by checking out commits in:
> "git log --oneline -- t/t3701-add-interactive.sh"
> I don't know if it is normal to have broken tests in the main repository.
It's not normal to have broken tests in the repository; they should not exist.

However, it's not clear what breakage you are seeing. In my testing, I don't see any failures, either in a9f4a01760 or after applying your patch to "master". Can you provide more information about the failure you're experiencing?

Previous: Edwin FernandoNext: Edwin Fernando
Message 10 of 13 in “Avoid suppression of git's exit code in tests”
  1. Edwin FernandoMar 26, 2023
  2. [GSOC][PATCH 1/1] t3701: Avoid suppression of exit status of gitEdwin Fernando, Mar 26, 2023
  3. Andrei RybakMar 26, 2023
  4. Eric SunshineMar 27, 2023
  5. [GSOC][PATCH v2] t3701: don't lose "git" exit codes in test scriptsEdwin Fernando, Apr 1, 2023
  6. Andrei RybakApr 2, 2023
  7. [GSOC][PATCH v3] t3701: don't lose "git" exit codes in test scriptsEdwin Fernando, Apr 2, 2023
  8. Eric SunshineApr 2, 2023
  9. [GSOC][PATCH v4] t3701: don't lose "git" exit codes in test scriptsEdwin Fernando, Apr 2, 2023
  10. Eric SunshineApr 3, 2023
  11. Edwin FernandoApr 3, 2023
  12. Edwin FernandoApr 3, 2023
  13. Eric SunshineApr 3, 2023

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.