Re: [PATCH] rebase -i: respect to core.abbrev

From: Eric Sunshine <sunshine@sunshineco.com>
Date: Sep 29, 2013, 02:49 UTC
Message-ID: <CAPig+cTpSTrcPBa+Xs5Lw6bQ5TvSHqEh1tnEoZS6eX8Z9GTm4w@mail.gmail.com>
In-Reply-To: <20130928211013.54361E0090@blue.fi.intel.com>

On Sat, Sep 28, 2013 at 5:10 PM, Kirill A. Shutemov <kirill.shutemov@linux.intel.com> wrote:

Show 19 quoted lines

> collapse_todo_ids() uses `git rev-parse --short=7' to abbrev commit ids.
> Let's drop argument from --short to use default (7) or config value
> instead.
>
> Signed-off-by: Kirill A. Shutemov <kirill.shutemov@linux.intel.com>
> ---
>  git-rebase--interactive.sh | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/git-rebase--interactive.sh b/git-rebase--interactive.sh
> index 10bf318d0d..3c6bed9a28 100644
> --- a/git-rebase--interactive.sh
> +++ b/git-rebase--interactive.sh
> @@ -713,7 +713,7 @@ expand_todo_ids() {
>  }
>
>  collapse_todo_ids() {
> -       transform_todo_ids --short=7
> +       transform_todo_ids --short

Thanks, I was going to suggest this exact simplification upon reading v1.

Acked-by: Eric Sunshine <sunshine@sunshineco.com>

Show 5 quoted lines

>  }
>
>  # Rearrange the todo list that has both "pick sha1 msg" and
> --
>  Kirill A. Shutemov