Re: What's cooking in git.git (May 2025, #02; Mon, 5)
- From
Eric Sunshine <sunshine@sunshineco.com>
- Date
- May 6, 2025, 17:50 UTC
- Message-ID
- <CAPig+cTnxJ+ff2jygfsuigQbSa9QMdA1dWN+Wp4xXJQRXOvwOA@mail.gmail.com>
- In-Reply-To
- <CAP8UFD3=SJp29+QaUZvqWhjx_53P9tOE05j9TgP-sEvNRZW-oA@mail.gmail.com>
On Tue, May 6, 2025 at 4:35 AM Christian Couder <christian.couder@gmail.com> wrote:
Show 19 quoted lines
> On Tue, May 6, 2025 at 9:04 AM Junio C Hamano <gitster@pobox.com> wrote: > > * ps/maintenance-missing-tasks (2025-05-05) 7 commits > > - builtin/maintenance: introduce "rerere-gc" task > > - builtin/gc: move rerere garbage collection into separate function > > - builtin/maintenance: introduce "worktree-prune" task > > - worktree: expose function to retrieve worktree names > > - builtin/gc: move pruning of worktrees into a separate function > > - builtin/gc: remove global variables where it trivial to do > > - builtin/gc: fix indentation of `cmd_gc()` parameters > > > > Make repository clean-up tasks "gc" can do available to "git > > maintenance" front-end. > > > > Will merge to 'next'. > > source: <20250505-pks-maintenance-missing-tasks-v4-0-141f4df906a1@pks.im> > > I am reviewing this series and it seems to me that it's possibly > missing a fix for a leak that Eric Sunshine had found in a previous > review round.
In addition to the leak[1], I also have reservations[2] about the "worktree: expose function to retrieve worktree names" patch.
[1]: https://lore.kernel.org/git/CAPig+cScor=E2i4w99NCrsaUd-Po=FqhkrLSyT69PSo1+h2dRw@mail.gmail.com/ [2]: https://lore.kernel.org/git/CAPig+cSDDbhGrym8j=PFKBCUxBQhZPzAHXGvKy-Z6POA4Ju3sw@mail.gmail.com/