Re: [PATCH v2 0/3] Improving performance of git clean
On Sat, Apr 11, 2015 at 12:43 PM, Erik Elfström <erik.elfstrom@gmail.com> wrote:
Show 25 quoted lines
> v1 of the patch can be found here:
> http://thread.gmane.org/gmane.comp.version-control.git/266839/focus=266839
>
> changes in v2:
> * fixed commit message,
> "p7300: added performance tests for clean"
> change to:
> "p7300: add performance tests for clean"
> * simplified test code
> * removed non portable ls -A in test
> * removed non portable $(seq ) in test
> * fixed missing " || return $?" in test
> * fixed missing sub shell for 'cd' command in test
> * fixed broken && chains in test
> * added assert new clean.c:is_git_repository to guard against
> negative array index
> * use size_t instead of int for strbuf->len
>
> fixes held back for cleanup patches:
> * fixed existing broken && chains
> * added assert in existing code to guard against
> negative array index
>
> Thanks to Eric Sunshine and Torsten Bögershausen for the very helpful
> review!
Thanks. This version looks much better.
Eric Sunshine <sunshine@sunshineco.com>