Re: [GSoC][Newbie] Test Script Enhancements

From: Eric Sunshine <sunshine@sunshineco.com>
Date: Jan 5, 2025, 09:51 UTC
Message-ID: <CAPig+cTjK3_jme88H8D5AiXAoGc+Donu0tgBGYcS2F-KQ0Kfaw@mail.gmail.com>
In-Reply-To: <CAKz1=ZOY7GziF9DNTLXv=G+OX8_vAbvOYS4L2s-D2C3kpr-zOg@mail.gmail.com>

On Sun, Jan 5, 2025 at 4:39 AM Rhythm Narula <rhythm.narula26@gmail.com> wrote:

Show 10 quoted lines

> 1. Avoid suppressing git’s exit code in test scripts
> a.  diff --git a/t/t5801-remote-helpers.sh b/t/t5801-remote-helpers.sh
> @@ -271,7 +271,7 @@ test_expect_success 'push update refs failure' '
>  clean_mark () {
>         cut -f 2 -d ' ' "$1" |
> -       git cat-file --batch-check |
> +       git cat-file --batch-check >actual &&
>         grep commit |
>         sort >$(basename "$1")
>  }

At a quick glance, I'd say that this change is incomplete and won't work as you expect.

> 2. Modernize a test script
> Is there anyone working on t/t5801-remote-helpers.sh? Can I take this up?

No need to ask before working on something in Git. You're free to pick any modernization. A good way to check if anyone is touching this particular script is to search the mail archive[*] for recent mentions of "t5801".

[*]: https://lore.kernel.org/git/