Re: [PATCH] config.txt: add trailer.* variables

From: Eric Sunshine <sunshine@sunshineco.com>
Date: Jan 24, 2025, 15:48 UTC
Message-ID: <CAPig+cTj5Rwp8=KA-r6SkZaf=VpqSieD-p2FgGFoMW2zmnr0Uw@mail.gmail.com>
In-Reply-To: <pull.1871.git.git.1736429142334.gitgitgadget@gmail.com>

On Thu, Jan 9, 2025 at 8:25 AM Julian Prein via GitGitGadget <gitgitgadget@gmail.com> wrote:

> The trailer.* configuration variables are currently only described in
> git-interpret-trailers(1) but affect git-commit and git-tag as well.
> Move that section into its own config/trailer.txt file and also include
> it in git-config(1).

Makes sense. git-commit.txt and git-tag.txt do indeed reference these variables, and one would expect them to be mentioned by Documentation/config.txt, as well.

Show 9 quoted lines

> Signed-off-by: Julian Prein <julian@druckdev.xyz>
> ---
> diff --git a/Documentation/config.txt b/Documentation/config.txt
> @@ -540,6 +540,8 @@ include::config/tar.txt[]
>  include::config/trace2.txt[]
>
> +include::config/trailer.txt[]
> +
>  include::config/transfer.txt[]

Nice to see that you maintained alphabetical ordering here[*].

[*]: 5f78d52dce (docs: sort configuration variable groupings alphabetically, 2024-02-29)