Re: [PATCH 1/5] worktree: add skeleton "repair" command
- From
Eric Sunshine <sunshine@sunshineco.com>
- Date
- Aug 27, 2020, 19:30 UTC
- Message-ID
- <CAPig+cTeGA7i2a8A9N1z00f_D06cwCSqWvJZidjGBRVAxBJaUw@mail.gmail.com>
- In-Reply-To
- <xmqqr1rsqdga.fsf@gitster.c.googlers.com>
On Thu, Aug 27, 2020 at 12:08 PM Junio C Hamano <gitster@pobox.com> wrote:
Show 6 quoted lines
> Eric Sunshine <sunshine@sunshineco.com> writes: > > At this stage, the "repair" command is a mere skeleton; subsequent > > commits will flesh out the functionality. > > Sounds good. It looked a bit odd to have skeleton test script only > to reserve its test number, but it is just odd and not wrong.
The intent wasn't to reserve a test number. Rather, I was worried about reviewer fatigue with patches [2/5] and [3/5] which are lengthy, so I moved whatever boilerplate I could to [1/5] to make the later patches a tiny bit shorter.