Re: [PATCH 2/6] Documentation/config: mention "now" and "never" for 'expire' settings
- From
Eric Sunshine <sunshine@sunshineco.com>
- Date
- Jul 28, 2015, 17:33 UTC
- Message-ID
- <CAPig+cTbTi5Uj_BFWBQ+rDc0=PhY1pu9Emr9TwTwPzGCeE5J2A@mail.gmail.com>
- In-Reply-To
- <55B58C3B.7040200@alum.mit.edu>
[+cc:Paul Tan]
On Sun, Jul 26, 2015 at 9:41 PM, Michael Haggerty <mhagger@alum.mit.edu> wrote:
Show 20 quoted lines
> On 07/23/2015 09:00 PM, Eric Sunshine wrote:
>> In addition to approxidate-style values ("2.months.ago", "yesterday"),
>> consumers of 'gc.*expire*' configuration variables also accept and
>> respect 'now'/'all' ("do it immediately") and 'never'/'false' ("suppress
>> entirely").
>>
>> Suggested-by: Michael Haggerty <mhagger@alum.mit.edu>
>> Signed-off-by: Eric Sunshine <sunshine@sunshineco.com>
>> ---
>> gc.pruneExpire::
>> When 'git gc' is run, it will call 'prune --expire 2.weeks.ago'.
>> Override the grace period with this config variable. The value
>> - "now" may be used to disable this grace period and always prune
>> - unreachable objects immediately.
>> + "now" may be used to disable this grace period and always prune
>> + unreachable objects immediately; or "never" to suppress pruning.
>
> A semicolon should be used without a conjunction, and the parts of a
> sentence joined by a semicolon should be independent clauses. So this
> should probably beI was just getting ready to re-roll this series[1] to address Michael's comments[2] and noticed that the add-on patch 7/6 which I sent later[3] seems to have been botched when Junio applied it to 'pu'. It's currently at 36598db (Documentation/git-tools: drop references to defunct tools, 2015-07-24) in es/doc-clean-outdated-tools and it appears that the --scissors option didn't cut off the leading cruft from the email conversation, thus the commit has the wrong "subject" plus a bunch of email conversation gunk in the commit message which doesn't belong. I understand that Junio uses a relatively bleeding-edge version of Git for his day-to-day work and was wondering if this is possible fallout from the git-am rewrite in C?
[1]: http://thread.gmane.org/gmane.comp.version-control.git/274537 [2]: http://article.gmane.org/gmane.comp.version-control.git/274647 [3]: http://article.gmane.org/gmane.comp.version-control.git/274602