git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] t4200: drop irrelevant code

From
Eric Sunshine <sunshine@sunshineco.com>
Date
Jul 19, 2022, 05:21 UTC
Message-ID
<CAPig+cTb30T0Yq2MdrrT3zuq3_YVEAXia79rgReH0wrQpzHuKg@mail.gmail.com>
In-Reply-To
<20220718154322.2177166-1-martin.agren@gmail.com>
On Mon, Jul 18, 2022 at 11:45 AM Martin Ågren <martin.agren@gmail.com> wrote:
Show 15 quoted lines
> While setting up an unresolved merge for `git rerere`, we run `git
> rev-parse` and `git fmt-merge-msg` to create a variable `$fifth` and a
> commit-message file `msg`, which we then never actually use. This has
> been like that since these tests were added in 672d1b789b ("rerere:
> migrate to parse-options API", 2010-08-05). This does exercise `git
> rev-parse` and `git fmt-merge-msg`, but doesn't contribute to testing
> `git rerere`. Drop these lines.
>
> Reported-by: Eric Sunshine <sunshine@sunshineco.com>
> Signed-off-by: Martin Ågren <martin.agren@gmail.com>
> ---
>  This is quite late fallout from Eric's review [1] of some commits that
>  have already gone in.
>
>  [1] https://lore.kernel.org/git/CAPig+cSjHg2-WYqdkZAS0ye1goj_=5RN3mdjt0-4kSBqNm6WLg@mail.gmail.com/
Thanks for following up on this. The patch looks fine.
Previous: Junio C Hamano
Message 3 of 3 in “t4200: drop irrelevant code”
  1. t4200: drop irrelevant codeMartin Ågren, Jul 18, 2022
  2. Junio C HamanoJul 18, 2022
  3. Eric SunshineJul 19, 2022

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.