Re: [PATCH v12 00/13] port tag.c to use ref-filter.c APIs

From: Eric Sunshine <sunshine@sunshineco.com>
Date: Aug 18, 2015, 19:18 UTC
Message-ID: <CAPig+cTauPEH5dTemwMcq0oE2WgKfcWKcK6-mvs8C7HUNqC4Bw@mail.gmail.com>
In-Reply-To: <1439923052-7373-1-git-send-email-Karthik.188@gmail.com>

On Tue, Aug 18, 2015 at 2:37 PM, Karthik Nayak <karthik.188@gmail.com> wrote:

Show 26 quoted lines

> Version 11 was posted here:
> http://article.gmane.org/gmane.comp.version-control.git/275997
>
> Changes in this version:
> * Small style and formatting changes.
> * Remove unnecessary variable from push_new_state().
> * pop_state doesn't return a value now and attaches the buffer
>   into the previous state.
> * use strcmp() rather than starts_with() while checking for
>   alignment position.
> * Change attend to at_end
>
> Interdiff:
>
> diff --git a/Documentation/git-for-each-ref.txt b/Documentation/git-for-each-ref.txt
> index 3099631..760d719 100644
> --- a/Documentation/git-for-each-ref.txt
> +++ b/Documentation/git-for-each-ref.txt
> @@ -128,8 +128,8 @@ color::
>         are described in `color.branch.*`.
>
>  align::
> -       left-, middle-, or right-align the content between %(align:..)
> -       and %(end). Followed by `:<position>,<width>`, where the
> +       Left-, middle-, or right-align the content between %(align:..)
> +       and %(end). Followed by `:<width>>,<position>`, where the

I haven't had a chance to look closely at this version yet, but this popped out while quickly scanning the interdiff since the previous round had the same sort of problem:

    s/>>/>/

>         `<position>` is either left, right or middle and `<width>` is
>         the total length of the content with alignment. If the
>         contents length is more than the width then no alignment is