Re: [PATCH 1/2] upload-pack: send keepalive packets during pack computation

From: Eric Sunshine <sunshine@sunshineco.com>
Date: Sep 9, 2013, 07:45 UTC
Message-ID: <CAPig+cTa2QYtQZ-kFCTTvhHC+saJS1o=5CyFwfwARXxg8sn-uA@mail.gmail.com>
In-Reply-To: <20130908090131.GA17060@sigill.intra.peff.net>

On Sun, Sep 8, 2013 at 5:01 AM, Jeff King <peff@peff.net> wrote:

> Whenn upload-pack has started pack-objects, there may be a

s/Whenn/When/

Show 16 quoted lines

> quiet period while pack-objects prepares the pack (i.e.,
> counting objects and delta compression).  Normally we would
> see (and send to the client) progress information, but if
> "--quiet" is in effect, pack-objects will produce nothing at
> all until the pack data is ready. On a large repository,
> this can take tens of seconds (or even minutes if the system
> is loaded or the repository is badly packed). Clients or
> intermediate proxies can sometimes give up in this
> situation, assuming that the server or connection has hung.
>
> This patch introduces a "keepalive" option; if upload-pack
> sees no data from pack-objects for a certain number of
> seconds, it will send an empty sideband data packet to let
> the other side know that we are still working on it.
>
> Signed-off-by: Jeff King <peff@peff.net>