Re: BUG: Git path --config doesn't work with ~ symbol

From: Eric Sunshine <sunshine@sunshineco.com>
Date: May 5, 2021, 18:21 UTC
Message-ID: <CAPig+cTX179z5MrTvSmgYGzZdc4xz=2G_ffHsyVOXsKVHrL93w@mail.gmail.com>
In-Reply-To: <YJLgmXS/fJm1BQb4@coredump.intra.peff.net>

On Wed, May 5, 2021 at 2:14 PM Jeff King <peff@peff.net> wrote:

Show 14 quoted lines

> On Wed, May 05, 2021 at 09:06:12PM +0300, Theodor Negrescu wrote:
> > I ran the command "git config --file ~/git-settings/.gitconfig -l"
> > (git-settings is a repo where I keep my config, the global one is just
> > an include)
>
> I don't think this is a bug in git-config. It is generally the shell
> that is responsible for expanding "~" and passing along the result to
> commands. E.g.:
>
>   $ strace -e execve git config --file ~/foo --list
>   execve("/home/peff/local/git/current/bin/git", ["git", "config", "--file", "/home/peff/foo", "--list"], 0x7ffc10a88130 /* 55 vars */) = 0
>
> I'd guess this might be related to Windows somehow. Are you entering the
> command in a bash shell, or via some other mechanism?

Is OPT_FILENAME supposed to handle tilde-expansion? I ask because git-config is using OPT_STRING for this option, whereas other commands use OPT_FILENAME for their `--file` options.