Re: [PATCH v2 0/3] Additional FAQ entries

From: Eric Sunshine <sunshine@sunshineco.com>
Date: Nov 8, 2021, 00:16 UTC
Message-ID: <CAPig+cTWwmVFggD2UL=Ddd3rc007zRWcRs7nQtEHSS5kgjx4og@mail.gmail.com>
In-Reply-To: <20211107225525.431138-1-sandals@crustytoothpaste.net>

On Sun, Nov 7, 2021 at 5:55 PM brian m. carlson <sandals@crustytoothpaste.net> wrote:

Show 12 quoted lines

> This series introduces some additional Git FAQ entries on various
> topics.  They are all things I've seen in my professional life or on
> Stack Overflow, so I've written documentation.
>
> Changes from v1:
> * Drop the monorepo patch for now; I want to revise it further.
> * Reorder the working tree patch to place more warnings up front.
> * Mention core.gitproxy and socat.
> * Rephrase text in the EOL entry to read correctly and be easier to
>   understand.
> * Improve the commit message for the working tree FAQ entry to make it
>   clearer that users wish to transfer uncommitted changes.

Thanks for re-rolling. FAQ entries are, of course, bikeshedding fodder, so I left a number of bikeshedding comments and pointed out one minor typo. Whether any of the comments warrant a re-roll or are even worth discussing is a matter of opinion, and they could certainly all be addressed later (by someone) atop the current series if desired; I don't think any of the comments were blockers.