Re: [PATCH v6 0/6] ref-filter: remove die() calls from formatting logic

From: Eric Sunshine <sunshine@sunshineco.com>
Date: Mar 30, 2018, 00:16 UTC
Message-ID: <CAPig+cTWKXrWggWO5EXA9dvpgW8rzZs=+XN3TK2GN4dM_gPiKg@mail.gmail.com>
In-Reply-To: <CAP8UFD2EjZ9-qeS-3oWWS8O8ayP92aXAxAb1qK9qjKKqDh7y2g@mail.gmail.com>

On Thu, Mar 29, 2018 at 10:41 AM, Christian Couder <christian.couder@gmail.com> wrote:

Show 11 quoted lines

> On Thu, Mar 29, 2018 at 2:52 PM, Оля Тележная <olyatelezhnaya@gmail.com> wrote:
>> Move helper function from strbuf to ref-filter.
>> Get rid of some memory leaks.
>
> The above seems to be the changes since v5. Usually in a cover letter
> (patch 0/X) there is both information about the goal of the patch
> series and the changes since last version.
>
> Repeating the goal in each version is useful for reviewers who might
> not have time to look at the patch series before, or who might have
> forgotten about it.

Another important way to help both returning and new reviewers is to provide a link to the previous iteration (or iterations), like this[1].

Thanks.

[1]: https://public-inbox.org/git/0102016249d21c40-0edf6647-4d26-46fc-8cfd-5a446b93a5e2-000000@eu-west-1.amazonses.com/