Re: [PATCH v2 1/2] list-objects-filter: only parse sparse OID when 'have_git_dir'
- From
Eric Sunshine <sunshine@sunshineco.com>
- Date
- Aug 29, 2019, 23:48 UTC
- Message-ID
- <CAPig+cTUEY9Z7KBqXXcvrjBzRVQJ6pJUi72BrevquN1xfvwZag@mail.gmail.com>
- In-Reply-To
- <d8f1b891-4ff7-9815-2405-76e53506027c@jonsimons.org>
On Thu, Aug 29, 2019 at 7:12 PM Jon Simons <jon@jonsimons.org> wrote:
Show 11 quoted lines
> On 8/29/19 3:45 PM, Eric Sunshine wrote: > > On Thu, Aug 29, 2019 at 6:38 PM Jon Simons <jon@jonsimons.org> wrote: > >> + test_write_lines /* >sparse-src/all-files && > > > > Hmm, does this work correctly? I would expect the /* to expand to all > > names at the root of your filesystem, which isn't what you want. You > > want the literal string "/*", which means you should quote it (with > > double quotes inside the test body). [...] > > Oof, thanks -- yes, this is incorrect. I will revert this back to > 'echo'. I misapplied your initial suggesttion to all three lines.
Curious. Did the test still pass even with the unquoted "/*"? If so, does that indicate a flaw in the test or somewhere else?