Re: [GSoC][PATCH 2/2] attrs: add "css" to the list of userdiff bulit-in patterns

From: Eric Sunshine <sunshine@sunshineco.com>
Date: Mar 8, 2015, 23:02 UTC
Message-ID: <CAPig+cTTy+Thkpb-jR9e5PGq_NN2Z+wgRB=csgo5Z0Y39M_ZFg@mail.gmail.com>
In-Reply-To: <1425812624-6671-2-git-send-email-sh19910711@gmail.com>

On Sun, Mar 8, 2015 at 7:03 AM, Hiroyuki Sano <sh19910711@gmail.com> wrote:

> attrs: add "css" to the list of userdiff bulit-in patterns

s/bulit/built/

Show 11 quoted lines

> Signed-off-by: Hiroyuki Sano <sh19910711@gmail.com>
> ---
> diff --git a/Documentation/gitattributes.txt b/Documentation/gitattributes.txt
> index c892ffa..8904a2a 100644
> --- a/Documentation/gitattributes.txt
> +++ b/Documentation/gitattributes.txt
> @@ -525,6 +525,8 @@ patterns are available:
>
>  - `csharp` suitable for source code in the C# language.
>
> +- `css` suitable for source code in the CSS documents.

Taking a hint from the 'html' case, it might make more sense to say:

    `css` suitable for CSS documents.

Considering how directly related this change is to those in patch 1, it's not clear why this change needs a separate patch, so folding them into a single patch might be sensible.

Show 6 quoted lines

> +
>  - `fortran` suitable for source code in the Fortran language.
>
>  - `html` suitable for HTML/XHTML documents.
> --
> 2.3.1