Re: [PATCH v4 1/1] commit-reach: properly peel tags and clear flags
- From
Eric Sunshine <sunshine@sunshineco.com>
- Date
- Sep 25, 2018, 05:17 UTC
- Message-ID
- <CAPig+cTT9cpDPyWugg8WNmCdA7OhEOxVxTxD3FRhpf7Sgdg-zA@mail.gmail.com>
- In-Reply-To
- <a0a3cf01343381281554d0e175b2f4ec5fbe0abb.1537822669.git.gitgitgadget@gmail.com>
On Mon, Sep 24, 2018 at 4:58 PM Derrick Stolee via GitGitGadget <gitgitgadget@gmail.com> wrote:
Show 11 quoted lines
> diff --git a/commit-reach.c b/commit-reach.c
> @@ -544,20 +544,42 @@ int can_all_from_reach_with_flag(struct object_array *from,
> {
> + from_one = deref_tag(the_repository, from_one,
> + "a from object", 0);
> + if (!from_one || from_one->type != OBJ_COMMIT) {
> + /* no way to tell if this is reachable by
> + * looking at the ancestry chain alone, so
> + * leave a note to ourselves not to worry about
> + * this object anymore.
> + */Style nit:
/*
* Multi-line comment
* formatting.
*/