Re: Unitialised pointer free in is_crontab_available

From: Eric Sunshine <sunshine@sunshineco.com>
Date: Oct 17, 2024, 06:57 UTC
Message-ID: <CAPig+cTNUNCftpr28F6USxVDm-2UZt+x9NxHJ+zbX3Daf5thBg@mail.gmail.com>
In-Reply-To: <CAGGBzXLN6eFZmgEE=KBp9vbcgYGGEbDJDUrfyVeYjuCrRiYcXA@mail.gmail.com>

On Thu, Oct 17, 2024 at 2:48 AM Dima Tisnek <dimaqq@gmail.com> wrote:

Show 8 quoted lines

> This code will try to `free(cmd)` even if get_schedule_cmd returned 0,
> when it's safe to assume that &cmd was not allocated.
>
> If I read this right, as long as the special env var is not set, this
> function returns 0 and does not populate *out.
>
> Reproduce:
> run `git maintenance start` on a mac in some git repo

Does [1] resolve the problem for you?

[1]: https://lore.kernel.org/git/a5b1433abfd84cb627efc17f52e0d644ee207bb0.1728538282.git.ps@pks.im/