Re: [PATCH 13/18] sequencer: simplify memory allocation of get_message
On Mon, Feb 15, 2016 at 4:56 PM, Jeff King <peff@peff.net> wrote:
> For a commit with has "1234abcd" and subject "foo", this
Did you mean s/with has/which has ID/ or something?
Show 22 quoted lines
> function produces a struct with three strings:
>
> 1. "foo"
>
> 2. "1234abcd... foo"
>
> 3. "parent of 1234abcd... foo"
>
> It takes advantage of the fact that these strings are
> subsets of each other, and allocates only _one_ string, with
> pointers into the various parts. Unfortunately, this makes
> the string allocation complicated and hard to follow.
>
> Since we keep only one of these in memory at a time, we can
> afford to simply allocate three strings. This lets us build
> on tools like xstrfmt and avoid manual computation.
>
> While we're here, we can also drop the ad-hoc
> reimplementation of get_git_commit_encoding(), and simply
> call that function.
>
> Signed-off-by: Jeff King <peff@peff.net>
Eric Sunshine <sunshine@sunshineco.com>