Re: [PATCH v2] fetch-pack: parameterize message containing 'ready' keyword

From: Eric Sunshine <sunshine@sunshineco.com>
Date: Nov 18, 2021, 11:42 UTC
Message-ID: <CAPig+cTKNYCoiRiDyi-KxxvheiYJ4rAxFY7vHx-r+qNyXYHNjA@mail.gmail.com>
In-Reply-To: <20211118103424.6464-1-bagasdotme@gmail.com>

On Thu, Nov 18, 2021 at 5:35 AM Bagas Sanjaya <bagasdotme@gmail.com> wrote:

Show 13 quoted lines

> The protocol keyword 'ready' isn't meant for translation. Pass it as
> parameter instead of spell it in die() message (and potentially confuse
> translators).
>
> Signed-off-by: Bagas Sanjaya <bagasdotme@gmail.com>
> ---
> diff --git a/fetch-pack.c b/fetch-pack.c
> @@ -1410,9 +1410,13 @@ static int process_ack(struct fetch_negotiator *negotiator,
>         if (*received_ready && reader->status != PACKET_READ_DELIM)
> -               die(_("expected packfile to be sent after 'ready'"));
> +               /* TRANSLATORS: The parameter will be 'ready', a protocol
> +                * keyword */
> +               die(_("expected packfile to be sent after '%s"), "ready");

Missing closing single-quote after %s.

Show 5 quoted lines

>         if (!*received_ready && reader->status != PACKET_READ_FLUSH)
> -               die(_("expected no other sections to be sent after no 'ready'"));
> +               /* TRANSLATORS: The parameter will be 'ready', a protocol
> +                * keyword */
> +               die(_("expected no other sections to be sent after no '%s"), "ready");

Missing closing single-quote after %s.

>         return 0;
>  }