Re: [PATCH v2] contrib: git-cpcover: copy cover letter

From: Eric Sunshine <sunshine@sunshineco.com>
Date: Dec 4, 2019, 05:18 UTC
Message-ID: <CAPig+cTFbpAo5+kahLT+7E1zQe24S5icm0SSB=HF4xqsD2VdAA@mail.gmail.com>
In-Reply-To: <20191204044449.GB226135@google.com>

On Tue, Dec 3, 2019 at 11:45 PM Jonathan Nieder <jrnieder@gmail.com> wrote:

Show 12 quoted lines

> Michael S. Tsirkin wrote:
> > My flow looks like this:
> > 2. vi <dir>/v<n-1>-0000-cover-letter.patch <dir>/v<n>-0000-cover-letter.patch
> > copy subject and blurb, avoiding patchset stats
> > 3. add changelog update blurb as appropriate
> >
> > The following perl script automates step 2 above.
>
> Neat.  I wonder, should "git format-patch" learn an option for this?
>         git format-patch -v<n> --cover-letter \
>                 --last-cover-letter=<dir>/v<n-1>-0000-cover-letter.patch \
>                 -o <dir>

That was my first thought, as well, although, as this has similar purpose to the new git-format-patch --cover-from-description= option, perhaps a more suitable name might be --copy-cover-from= or something?

I could even imagine a new option -V<n> which has the combined effect of setting the re-roll count (like -v) and automagically copying the cover letter material from cover letter v<n-1> located in <dir>.