Re: [v3RFC] systemd socket activation support
- From
Eric Sunshine <sunshine@sunshineco.com>
- Date
- Apr 3, 2015, 23:06 UTC
- Message-ID
- <CAPig+cTFRz=b=hdsuP_v_1jzu9-utGEWQM_rkhpEBvq-chrZig@mail.gmail.com>
- In-Reply-To
- <1428100224-29441-1-git-send-email-shawn@churchofgit.com>
On Fri, Apr 3, 2015 at 6:30 PM, Shawn Landden <shawn@churchofgit.com> wrote:
> systemd supports git-daemon's existing --inetd mode as well. > > v2: actually test... > v3: make optional, switch to libsystemd
Every issue raised by my review[1] of v2 still applies to v3, so I won't bother repeating them here, however, there is one comment (below) new to this version of the patch.
[1]: http://article.gmane.org/gmane.comp.version-control.git/266650
Show 33 quoted lines
> shawn@zephyr:~/git/git$ ldd /lib/x86_64-linux-gnu/libsystemd.so.0 > linux-vdso.so.1 (0x00007ffeba7ec000) > libcap.so.2 => /lib/x86_64-linux-gnu/libcap.so.2 (0x00007fea158fe000) > libm.so.6 => /lib/x86_64-linux-gnu/libm.so.6 (0x00007fea155f9000) > librt.so.1 => /lib/x86_64-linux-gnu/librt.so.1 (0x00007fea153f0000) > libselinux.so.1 => /lib/x86_64-linux-gnu/libselinux.so.1 (0x00007fea151cb000) > liblzma.so.5 => /lib/x86_64-linux-gnu/liblzma.so.5 (0x00007fea14fa8000) > libgcrypt.so.20 => /lib/x86_64-linux-gnu/libgcrypt.so.20 (0x00007fea14cc5000) > libresolv.so.2 => /lib/x86_64-linux-gnu/libresolv.so.2 (0x00007fea14aae000) > libdl.so.2 => /lib/x86_64-linux-gnu/libdl.so.2 (0x00007fea148aa000) > libpthread.so.0 => /lib/x86_64-linux-gnu/libpthread.so.0 (0x00007fea1468b000) > libc.so.6 => /lib/x86_64-linux-gnu/libc.so.6 (0x00007fea142e7000) > /lib64/ld-linux-x86-64.so.2 (0x00007fea15d5b000) > libattr.so.1 => /lib/x86_64-linux-gnu/libattr.so.1 (0x00007fea140e2000) > libpcre.so.3 => /lib/x86_64-linux-gnu/libpcre.so.3 (0x00007fea13e73000) > libgpg-error.so.0 => /lib/x86_64-linux-gnu/libgpg-error.so.0 (0x00007fea13c61000) > > ewwwww...and only for two tiny functions. > > Signed-off-by: Shawn Landden <shawn@churchofgit.com> > --- > diff --git a/Makefile b/Makefile > index 5f3987f..362af94 100644 > --- a/Makefile > +++ b/Makefile > @@ -1403,8 +1413,8 @@ ifdef NATIVE_CRLF > endif > > ifdef USE_NED_ALLOCATOR > - COMPAT_CFLAGS += -Icompat/nedmalloc > - COMPAT_OBJS += compat/nedmalloc/nedmalloc.o > + COMPAT_CFLAGS += -Icompat/nedmalloc > + COMPAT_OBJS += compat/nedmalloc/nedmalloc.o
You're sneaking in (whitespace) changes unrelated to the rest of the patch. Typically, such unrelated cleanups should be relegated to separate preparatory patches. (In this case, however, the change is probably unwarranted and likely accidental, but serves as a reminder to review patches before sending them out.)
Show 7 quoted lines
> endif > > ifdef GIT_TEST_CMP_USE_COPIED_CONTEXT > diff --git a/daemon.c b/daemon.c > index 9ee2187..16b9eda 100644 > --- a/daemon.c > +++ b/daemon.c