Re: Help needed: Tests failed While replacing char array with strbuf in bulk-checkin.c

From: Eric Sunshine <sunshine@sunshineco.com>
Date: Mar 3, 2014, 22:14 UTC
Message-ID: <CAPig+cTE7wtVpmjN=p56JB6avL8n_JhDC6g5cAgGcmJQ8OVt5g@mail.gmail.com>
In-Reply-To: <d7af2c2bcb07168ecddedf76ca776cd0@students.iiit.ac.in>

On Mon, Mar 3, 2014 at 4:11 PM, saikrishna.sripada <saikrishna.sripada@students.iiit.ac.in> wrote:

Show 22 quoted lines

> I am trying do complete the microproject 4, inorder to apply to GSOC.
> I have made the below changes:
>
> https://gist.github.com/anhsirksai/9334565
>
> Post my changes compilation is succes in the source directory.
> But when I ran the tests[make in t/ directory] my tests are failing saying
>
> "
>  free(): invalid pointer: 0x3630376532353636 ***
> ======= Backtrace: =========
> /lib/x86_64-linux-gnu/libc.so.6(+0x7eb96)[0x2b5f3b540b96]
> /home/saikrishna/Desktop/libcloud-0.14.1/sai/git/git[0x4fb829]
> /home/saikrishna/Desktop/libcloud-0.14.1/sai/git/git[0x47d425]
> /home/saikrishna/Desktop/libcloud-0.14.1/sai/git/git[0x4064ad]
> /home/saikrishna/Desktop/libcloud-0.14.1/sai/git/git[0x405a04]
> /home/saikrishna/Desktop/libcloud-0.14.1/sai/git/git[0x404cbd]
> /lib/x86_64-linux-gnu/libc.so.6(__libc_start_main+0xed)[0x2b5f3b4e376d]
> /home/saikrishna/Desktop/libcloud-0.14.1/sai/git/git[0x405109]
> "
>
> Can some one please help me with the memory allacation and strbuf_release()

Read the microproject text carefully and _fully_. It provides the clue you need to understand the problem.

    Rewrite bulk-checkin.c:finish_bulk_checkin() to use a strbuf for
    handling packname, and explain why this is useful. Also check if
    the first argument of pack-write.c:finish_tmp_packfile() can be
    made const.

If, after making a closer examination of the mentioned functions, the problem still eludes you, ask here again.