Re: [PATCH] status: -i shorthand for --ignored command line option

From: Eric Sunshine <sunshine@sunshineco.com>
Date: Aug 8, 2018, 07:34 UTC
Message-ID: <CAPig+cTD7XYbaPBzj36Eudrud80r-cz1CPLDsLA9CHJC6Yc-Qw@mail.gmail.com>
In-Reply-To: <20180808063926.11911-1-guriev-ns@ya.ru>

Thanks for the submission. A few comments below...

On Wed, Aug 8, 2018 at 2:48 AM Nicholas Guriev <guriev-ns@ya.ru> wrote:

> This short option saves the number of keys to press for the
> typically git-status command.
> ---

Your sign-off is missing. See Documentation/SubmittingPatches.

It's clear that a short name would be helpful to you, but you may need to work harder to convince others that it makes sense to squat an a short option name like 'i'. One argument you might use in the commit message in support of adding a short name to --ignored is that the related option --untracked-files already has a short name (-u).

>  builtin/commit.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

This patch neglects to update the documentation for git-status in Documentation/git-status.txt. It will need to do so if this change is ever to be accepted.